fix(amazonq): discard/reject edit suggestion if it isn't valid #7848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Will-ShaoHua
reviewed
Aug 8, 2025
Will-ShaoHua
reviewed
Aug 8, 2025
|
|
||
| const isPatchValid = applyPatch(e.document.getText(), item.insertText as string) | ||
| if (!isPatchValid) { | ||
| vscode.commands.executeCommand('aws.amazonq.inline.rejectEdit') |
Contributor
Author
There was a problem hiding this comment.
I explicitly didn't add an await since this is in documentChangeListener we want this to be fast
Will-ShaoHua
previously approved these changes
Aug 8, 2025
andrewyuq
changed the title
Will-ShaoHua
previously approved these changes
Aug 8, 2025
leigaol
reviewed
Aug 8, 2025
leigaol
reviewed
Aug 8, 2025
leigaol
approved these changes
Aug 8, 2025
Will-ShaoHua
approved these changes
Aug 8, 2025
laura-codess
pushed a commit
to laura-codess/aws-toolkit-vscode
that referenced
this pull request
Aug 11, 2025
) ## Problem discard when it's not yet shown. reject when user's typing and makes the diff invalid. ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
discard when it's not yet shown.
reject when user's typing and makes the diff invalid.
Solution
feature/xbranches will not be squash-merged at release time.